Skip to content

Use our canonical constants in SpatialCoordsRemapper instead of lowercase substring matching #1671

Description

@erogluorhan

Version

v2026.07.0

How did you install UXarray?

Source

What happened?

Nothing happened, but I just noticed a small fragility worth fixing in SpatialCoordsRemapper: _get_element_type_from_dimension does lowercase substring matching ("face" in dim_lower) to guess element type, but uxarray/conventions/ugrid.py already defines canonical NODE_DIM, FACE_DIM, EDGE_DIM constants that internal dimension names always match exactly.

What did you expect to happen?

Use constants instead of substring matching.

Can you provide a MCVE to repoduce the bug?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions