Skip to content

test: verify persisted membership expiration - #1738

Merged
superdav42 merged 1 commit into
mainfrom
feature/auto-20260822-180635-gh1737
Aug 23, 2026
Merged

test: verify persisted membership expiration#1738
superdav42 merged 1 commit into
mainfrom
feature/auto-20260822-180635-gh1737

Conversation

@superdav42

@superdav42 superdav42 commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Resolves #1737\n\n


aidevops.sh v3.32.286 plugin for OpenCode v1.18.18 with gpt-5.6-terra spent 3m and 84,229 tokens on this as a headless worker.

Summary by CodeRabbit

  • Tests
    • Improved coverage for recurring membership expiration by verifying persisted membership data, expiration formatting, and event payload values.
    • Enhanced test cleanup to remove reloaded membership records.

@superdav42 superdav42 added the origin:worker Auto-created by pulse labelless backfill (t2112) label Aug 23, 2026
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b0b3d0c4-8686-406a-82f6-dc4a83557ca1

📥 Commits

Reviewing files that changed from the base of the PR and between 9f4af51 and 07f7e7d.

📒 Files selected for processing (1)
  • tests/WP_Ultimo/Checkout/Checkout_Test.php

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The recurring membership expiration test now reloads the membership from persistence before checking expiration values, formatted output, event payload data, and cleanup.

Changes

Checkout membership validation

Layer / File(s) Summary
Persisted membership assertions
tests/WP_Ultimo/Checkout/Checkout_Test.php
The test reloads the membership with wu_get_membership(), validates persisted expiration values and event data, then deletes the reloaded membership.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 07f7e

This is a localized test-only change, and no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the test change: verifying persisted membership expiration.
Linked Issues check ✅ Passed The test retrieves the membership with wu_get_membership() before validating expiration and derived values, satisfying issue #1737.
Out of Scope Changes check ✅ Passed The changes are limited to the checkout test and directly support the linked issue objective.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/auto-20260822-180635-gh1737

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@superdav42
superdav42 marked this pull request as ready for review August 23, 2026 00:12
@superdav42

superdav42 commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator Author

\n\nSummary: Retrieve the new recurring membership from persistence before checking its expiration and derived event values.\n\nVerification: php -l tests/WP_Ultimo/Checkout/Checkout_Test.php; vendor/bin/phpcs tests/WP_Ultimo/Checkout/Checkout_Test.php; vendor/bin/phpunit --filter test_maybe_create_membership_recurring_product_without_trial_uses_next_charge_date\n\n


aidevops.sh v3.32.286 plugin for OpenCode v1.18.18 with gpt-5.6-terra spent 4m and 99,572 tokens on this as a headless worker.


Merged via PR #1738 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

Routing feedback

  • Route: standard; 1 attempt, 28 LLM requests, 0 capability escalations, 0 same-tier fallbacks.
  • Population: headless; 0 objective outcomes.
  • Usage: 2,507,158 tokens; $0.8469 estimated cost.
  • Recommendation: No routing change is recommended from this sample.

@ultimate-multisite ultimate-multisite Bot added the status:in-review PR open, awaiting review/merge label Aug 23, 2026
@superdav42
superdav42 merged commit b835de9 into main Aug 23, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

origin:worker Auto-created by pulse labelless backfill (t2112) status:in-review PR open, awaiting review/merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review followup: PR #1692 — fix(checkout): prevent epoch membership expiration

1 participant