fix preprocess to expand properties dict instead of add as a node to … - #86
Open
ryanmco wants to merge 5 commits into
Open
fix preprocess to expand properties dict instead of add as a node to …#86ryanmco wants to merge 5 commits into
ryanmco wants to merge 5 commits into
Conversation
…avoid traversing properties with names that match json schema keywords.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid traversing properties with names that match json schema keywords.
Error occurs when processing common/types/constraint_expression.json
This is fixed by instead adding the properties mapping itself (the container dictionary { "prop_name": { ...schema... } }), it immediately adds each property's inner schema dictionary (v.values()) directly to the traversal list.
Before vs After
Before
After (with the fix):
Yields root object { "type": "object", "properties": { ... } }
Yields { "type": "string", "$ref": "#/$defs/id" } (container is skipped)
Yields { "type": "object", ... }
This prevents functions inspecting yielded nodes (like checking for anyOf, properties,...) from the container map itself as if it were a schema.
Description
Category (Required)
Please select one or more categories that apply to this change.
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
Checklist
!for breaking changes).Screenshots / Logs (if applicable)