fix(a2a): map string product images to line item image_url - #208
Open
FanouZeng-TT wants to merge 1 commit into
Open
fix(a2a): map string product images to line item image_url#208FanouZeng-TT wants to merge 1 commit into
FanouZeng-TT wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_get_line_itemina2a/business_agent/src/business_agent/store.pyonlyhandles product images inside a
listguard, then checks the same valuefor
stragain inside that guard:The inner branch is unreachable, so a legal single-string
Product.imagenever reaches the line item's
item.image_url.Product.imageis declaredas
str | list[str] | list[ImageObject] | None, so all three non-nullshapes should project a URL onto the checkout line item.
Fix: handle a plain string first, then a non-empty list (first element
kept: a string as-is, an
ImageObjectmapped to.url). List behavior isunchanged; the single-string shape is restored.
Category (Required)
ucp-schematool (resolver, linter, validator). (Requires Maintainer approval)Related Issues
N/A
Checklist
!for breaking changes).Screenshots / Logs (if applicable)
item.image_url == Nonelist[str],list[ImageObject], andNoneall behave correctlyuv run --group dev ruff checkandruff format --checkuvx pre-commit run --all-filesgit diff --check