feat: npm audit - #227
Open
ieow wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
npm auditreported vulnerable transitive dependencies in the lockfile. This PR hardens the dependency tree by pinning patched versions via npmoverrides, and removes a few unused dev dependencies. No SDK or published runtime behavior changes are intended.Jira Link:
Description
overridesinpackage.jsonforlodash(^4.17.24),tmp(^0.2.7), andserialize-javascript(^7.0.5) so transitive packages resolve to patched versions flagged bynpm audit.package-lock.jsonto apply the overrides and dependency cleanup.@typescript-eslint/eslint-pluginandmocha(tests run via Node's built-in test runner).tests/importRecovery.spec.ts, importAsyncStorage, enableresetStore()during account reset for more reliable test isolation, and remove a debugconsole.log.How has this been tested?
npm installcompletes successfully with the updated lockfilenpm auditno longer reports the addressed transitive vulnerabilitiesnpm run lintpassesnpm testpasses (includingtests/importRecovery.spec.ts)Screenshots (if appropriate):
N/A — dependency and test maintenance only.
Types of changes
Checklist:
Note
Low Risk
Dependency and test-harness maintenance only; no intended SDK or runtime behavior changes beyond safer resolved package versions.
Overview
Addresses
npm auditfindings by forcing transitive packages to patched releases through newoverridesinpackage.jsonforlodash,tmp, andserialize-javascript, withpackage-lock.jsonupdated to match.Trims dev tooling by dropping direct
@typescript-eslint/eslint-pluginandmocha(tests already use Node’s built-in runner).tests/importRecovery.spec.tstightens isolation:AsyncStorageimport,resetStore()during account reset, and removal of a debug log.Reviewed by Cursor Bugbot for commit 5561a99. Bugbot is set up for automated code reviews on this repo. Configure here.