Skip to content

Code Quality: Use the null coalescing assignment operator for array initialization - #12912

Open
Soean wants to merge 2 commits into
WordPress:trunkfrom
Soean:code-quality/array-init-null-coalescing-assignment
Open

Code Quality: Use the null coalescing assignment operator for array initialization#12912
Soean wants to merge 2 commits into
WordPress:trunkfrom
Soean:code-quality/array-init-null-coalescing-assignment

Conversation

@Soean

@Soean Soean commented Aug 6, 2026

Copy link
Copy Markdown
Member

Description

Covering one recognizable idiom: initializing a container to an empty array before writing into it.

-if ( ! isset( $wp_meta_boxes[ $page ] ) ) {
-	$wp_meta_boxes[ $page ] = array();
-}
+$wp_meta_boxes[ $page ] ??= array();

Every one of the 58 changed sites has exactly this shape, an isset() guard whose entire body is a single = array(); assignment to the tested expression. There is no per-site judgement involved, which makes the change easy to verify: confirm the rule once, then scan.

Why this is safe

  • ??= requires PHP 7.4, which is already the minimum supported version.
  • ??= and ! isset() test the same condition, so the array is created in exactly the same cases.
  • Only blocks whose body is a single assignment were converted. Any guard containing further statements was skipped, since ??= would let those statements run unconditionally.
  • Nested initializations keep their order, so parent arrays are still created before their children:
    $wp_meta_boxes                      ??= array();
    $wp_meta_boxes[ $page ]             ??= array();
    $wp_meta_boxes[ $page ][ $context ] ??= array();
  • No behavior change.

Trac ticket: https://core.trac.wordpress.org/ticket/65823


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Soean added 2 commits August 6, 2026 15:02
…nitialization.

Replace `if ( ! isset( $x ) ) { $x = array(); }` with `$x ??= array();`, using the
null coalescing assignment operator introduced in PHP 7.4.
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props soean.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant