Code Quality: Use the null coalescing assignment operator for array initialization - #12912
Code Quality: Use the null coalescing assignment operator for array initialization#12912Soean wants to merge 2 commits into
Conversation
…nitialization.
Replace `if ( ! isset( $x ) ) { $x = array(); }` with `$x ??= array();`, using the
null coalescing assignment operator introduced in PHP 7.4.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Description
Covering one recognizable idiom: initializing a container to an empty array before writing into it.
Every one of the 58 changed sites has exactly this shape, an
isset()guard whose entire body is a single= array();assignment to the tested expression. There is no per-site judgement involved, which makes the change easy to verify: confirm the rule once, then scan.Why this is safe
??=requires PHP 7.4, which is already the minimum supported version.??=and! isset()test the same condition, so the array is created in exactly the same cases.??=would let those statements run unconditionally.Trac ticket: https://core.trac.wordpress.org/ticket/65823
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.