Media: Fix Image Editor buttons becoming unreachable via keyboard - #12921
Open
R1shabh-Gupta wants to merge 1 commit into
Open
Media: Fix Image Editor buttons becoming unreachable via keyboard#12921R1shabh-Gupta wants to merge 1 commit into
R1shabh-Gupta wants to merge 1 commit into
Conversation
R1shabh-Gupta
marked this pull request as ready for review
August 7, 2026 12:06
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imageEdit.focusManager()unconditionally settabindex="-1"on whichever element it moved focus to when the Image Editor dialog opened, either an admin notice or, when no notice was present, the first tabbable control in the dialog (such as the Crop button).This is necessary for the admin notice because it is a
<div>and is not natively focusable. However, native controls like<button>elements are already focusable and part of the normal Tab order. Addingtabindex="-1"removes them from that order, and the attribute was never removed afterward.As a result, when the dialog opened without a notice, the initially focused control was permanently removed from the keyboard Tab order. Repeated open and close cycles progressively affected more controls (Crop, then Scale, then the rotation control, and so on).
This PR limits the
tabindex="-1"assignment to the admin notice only. When no notice is present, focus is moved directly to the first tabbable control without modifying itstabindex, preserving the expected keyboard navigation.Trac ticket: https://core.trac.wordpress.org/ticket/65814
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Code Review & Testing
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.