Skip to content

Posts, Post Types: Preserve comment/ping status in Quick Edit when the control isn't rendered - #12925

Open
irozum wants to merge 2 commits into
WordPress:trunkfrom
irozum:fix/31977-quick-edit-ping-status-reset
Open

Posts, Post Types: Preserve comment/ping status in Quick Edit when the control isn't rendered#12925
irozum wants to merge 2 commits into
WordPress:trunkfrom
irozum:fix/31977-quick-edit-ping-status-reset

Conversation

@irozum

@irozum irozum commented Aug 7, 2026

Copy link
Copy Markdown

wp_ajax_inline_save() unconditionally defaults comment_status/ping_status to closed whenever those fields are absent from the Quick Edit POST data, on the assumption that an absent value means the checkbox was unchecked. That assumption breaks for post types that don't support comments/trackbacks at all (e.g. page, which supports comments but not trackbacks): the corresponding checkbox is never rendered in the Quick Edit form, so the field is always absent, and every Quick Edit save on such a post type silently resets its ping_status to closed even if it was previously open.

This fixes it by falling back to the post's current comment_status/ping_status (already fetched into $post earlier in the function) instead of hardcoding closed, so a status that Quick Edit has no control for is left untouched rather than being overwritten. This also fixes the same issue for Bulk Edit's "— No Change —" option, which submits the same empty value through the same code path.

Added a PHPUnit test reproducing the bug against the page post type and asserting ping_status is preserved across a Quick Edit save.

Trac ticket: https://core.trac.wordpress.org/ticket/31977

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5
Used for: Implementation, tests, and PR description. Reviewed by irozum.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props irozum.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant