Skip to content

[Fix] Queued messages no longer approve pending actions - #1318

Draft
zoomote[bot] wants to merge 5 commits into
mainfrom
fix/queued-input-approval-1k43hlevwo6pk
Draft

[Fix] Queued messages no longer approve pending actions#1318
zoomote[bot] wants to merge 5 commits into
mainfrom
fix/queued-input-approval-1k43hlevwo6pk

Conversation

@zoomote

@zoomote zoomote Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

What changed

Queued user input now reaches pending tool, command, MCP, and child-completion prompts as feedback instead of an implicit approval. The existing command_output flow-control exception remains non-draining.

The change includes focused unit coverage for both queue timing windows and a deterministic VS Code e2e that queues input while a child is completing, verifies the child processes it, and only then allows the parent to resume.

Why this change was made

Queued instructions could previously trigger yesButtonClicked, causing commands to run or delegated children to complete before processing the user's new direction. This fixes #1308 and establishes the explicit-approval invariant tracked under #355.

Impact

Users can safely steer a running task with queued input without bypassing approval controls. Explicit approvals and configured auto-approval continue to behave normally when no queued intervention is present.

Related PRs

@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/core/task/Task.ts 84.61% 0 Missing and 2 partials ⚠️
src/core/tools/ReadFileTool.ts 0.00% 0 Missing and 1 partial ⚠️
src/extension/api.ts 66.66% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Review process

This PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.

  1. Required CI checks pass.
  2. The workflow starts CodeRabbit automatically.
  3. For eligible human-authored PRs, CodeRabbit reviews and approves the latest commit.
  4. A human maintainer reviews and approves after CodeRabbit.

Current step: Mark the PR ready to start CodeRabbit after required CI passes.

@github-actions github-actions Bot added has-conflicts PR has merge conflicts with the base branch and removed has-conflicts PR has merge conflicts with the base branch labels Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Queued messages interfere with tool responses that require user interaction

2 participants