Skip to content

[Fix] Approval controls disappear when user scrolls through chat - #1448

Draft
zoomote[bot] wants to merge 1 commit into
mainfrom
fix/keep-approval-controls-visible-2rxure6hwxnz3
Draft

[Fix] Approval controls disappear when user scrolls through chat#1448
zoomote[bot] wants to merge 1 commit into
mainfrom
fix/keep-approval-controls-visible-2rxure6hwxnz3

Conversation

@zoomote

@zoomote zoomote Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

What changed

  • Keep pending approval controls visible beside a compact scroll-to-bottom action while users browse earlier chat output.
  • Prioritize approvals over the optional checkpoint shortcut and truncate long localized labels safely in narrow sidebars.
  • Add regression coverage that reproduces a scrolled child task receiving finishTask approval, including a prior checkpoint state.

Why this change was made

Scrolling previously replaced the entire action row with navigation controls. A child task waiting for completion approval therefore appeared stuck because the only control that could return to its parent was no longer rendered.

Closes #1447.

Impact

Users can approve subtask completion and other blocking actions without first changing their chat scroll position. The regression was developed test-first and the full repository suite passes. A post-fix extension screenshot is not included because this task's approved proof browser exposes only the documentation site, not the VS Code Extension Host surface.

Related PRs

@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
webview-ui/src/components/chat/ChatView.tsx 73.91% 1 Missing and 5 partials ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

Copy link
Copy Markdown
Contributor

Review process

This PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.

  1. Required CI checks pass.
  2. The workflow starts CodeRabbit automatically.
  3. For eligible human-authored PRs, CodeRabbit reviews and approves the latest commit.
  4. A human maintainer reviews and approves after CodeRabbit.

Current step: Mark the PR ready to start CodeRabbit after required CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Scrolling hides pending approval controls behind the scroll-to-bottom button

1 participant