[Fix] Approval controls disappear when user scrolls through chat - #1448
Draft
zoomote[bot] wants to merge 1 commit into
Draft
[Fix] Approval controls disappear when user scrolls through chat#1448zoomote[bot] wants to merge 1 commit into
zoomote[bot] wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Review processThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.
Current step: Mark the PR ready to start CodeRabbit after required CI passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
finishTaskapproval, including a prior checkpoint state.Why this change was made
Scrolling previously replaced the entire action row with navigation controls. A child task waiting for completion approval therefore appeared stuck because the only control that could return to its parent was no longer rendered.
Closes #1447.
Impact
Users can approve subtask completion and other blocking actions without first changing their chat scroll position. The regression was developed test-first and the full repository suite passes. A post-fix extension screenshot is not included because this task's approved proof browser exposes only the documentation site, not the VS Code Extension Host surface.
Related PRs