fix(grpc): transport validation and error message - #1026
Open
malladinagarjuna2 wants to merge 2 commits into
Open
fix(grpc): transport validation and error message#1026malladinagarjuna2 wants to merge 2 commits into
malladinagarjuna2 wants to merge 2 commits into
Conversation
Author
|
@kabir could you please verify |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1014
GrpcTransport- getTaskPushNotificationConfiguration(): Replaced a manual IllegalArgumentException null check with checkNotNullParam("id", request.id()) for consistency with the validation used throughout the class.
DataPart immutability (regression from #633)
PR #633 widened DataPart.data from Map<String, Object> to Object to support any JSON value (arrays, primitives), but in doing so dropped the data = Map.copyOf(data) defensive copy. As a result, callers could mutate the contents
of a DataPart after construction.
The widening itself is correct — the spec allows any JSON value — so the defensive copy is now applied based on the runtime type:
class-level docs and both constructor @param tags.
Tests- Added5 tests in DataPartTest verifying: