perf(spec): batch Ajv validations in validate.py - #2467
Open
jacobsimionato wants to merge 2 commits into
Open
Conversation
Batch all example data paths into a single Ajv CLI invocation per spec version instead of spawning Node/Ajv subprocesses 110+ times in a loop. Reduces overall specification validation time from ~45s to ~3s.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the validate_messages function in specification/scripts/validate.py to batch the validation of all example messages into a single run_ajv invocation, improving performance. It also updates the error handling to return immediately on JSON decoding or validation failures. There are no review comments, so no additional feedback is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR optimizes the specification validation script (
specification/scripts/validate.py) by batching Ajv schema validations.Key Changes:
node/ajvprocess for each of the 110+ example JSON files individually (~400ms per invocation),validate_messages()now batches all example message files for a given spec version into a singlerun_ajv()call.python3 specification/scripts/validate.pyfrom ~45 seconds down to ~3 seconds (a 14x speedup).Verification
python3 specification/scripts/validate.pyacross all test suites (v0.8, v0.9, v1.0).Overall Validation: PASSEDin 3.1s.