Add mypy type checking to CI (#226) - #2398
Open
AravCS wants to merge 4 commits into
Open
Conversation
Signed-off-by: AravCS <aravshah927@gmail.com>
Signed-off-by: AravCS <aravshah927@gmail.com> Co-authored-by: tristonfgibson <246780826+tristonfgibson@users.noreply.github.com> Co-authored-by: yaeger211202 <163278221+yaeger211202@users.noreply.github.com>
Collaborator
|
Hi @yaeger211202 and @tristonfgibson, I think it may be a good idea to use I think the best way to discuss this in more detail is to create an issue in https://github.com/aboutcode-org/skeleton/. If it proves useful, we can integrate it into all of our projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello me and my team, @yaeger211202 and @tristonfgibson worked on this as part of CodeDay Labs. Here is a summary of our changes:
Added mypy type checking to CI. Consists of already-clean, high-value modules as the initial whitelist target.
Rather than running mypy across the whole codebase (pre-existing errors), it uses a whitelist in mypy.ini, only the listed files are checked. This follows mypy’s existing-codebase docs by starting on a clean subset and expanding over time. Config uses mypy’s recommended foundation settings as well.
Changes pass both locally and on Github Actions (run on a fork against current main).
Changes: