Make SandboxConfig spec immutable; mark defaults via annotation - #1428
Open
Zoe Zhao (zoez7) wants to merge 1 commit into
Open
Make SandboxConfig spec immutable; mark defaults via annotation#1428Zoe Zhao (zoez7) wants to merge 1 commit into
Zoe Zhao (zoez7) wants to merge 1 commit into
Conversation
Zoe Zhao (zoez7)
force-pushed
the
sbcfg-immutable
branch
from
September 3, 2026 15:27
6f069e2 to
c2db275
Compare
Zoe Zhao (zoez7)
marked this pull request as ready for review
September 3, 2026 15:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Models after StorageClass in kubernetes.
sandboxconfig.ate.dev/is-default: "true"can be added or removed. If 2 configs of the same class are both annotated as default, the one created later will win.K8s storage class reference: https://github.com/kubernetes/kubernetes/blob/36102b645d1a26a5945bd79173a16594c56b6aea/pkg/volume/util/storageclass.go#L60