Skip to content

Make SandboxConfig spec immutable; mark defaults via annotation - #1428

Open
Zoe Zhao (zoez7) wants to merge 1 commit into
agent-substrate:mainfrom
zoez7:sbcfg-immutable
Open

Make SandboxConfig spec immutable; mark defaults via annotation#1428
Zoe Zhao (zoez7) wants to merge 1 commit into
agent-substrate:mainfrom
zoez7:sbcfg-immutable

Conversation

@zoez7

@zoez7 Zoe Zhao (zoez7) commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Models after StorageClass in kubernetes.

  • the annotation sandboxconfig.ate.dev/is-default: "true" can be added or removed. If 2 configs of the same class are both annotated as default, the one created later will win.
  • the spec field is immutable
apiVersion: ate.dev/v1alpha1
kind: SandboxConfig
metadata:
  name: gvisor-default
  annotations:
    sandboxconfig.ate.dev/is-default: "true"
spec:
  sandboxClass: gvisor
  pauseImage: ...
  assets:
    amd64:
      gvisor:
        url: "gs://gvisor/releases/nightly/2026-09-02/x86_64/gvisor.tar.zstd"
        sha256: "d547d81401461fd1c679c5c4fa0a6c2b8ef7dc3c22ce23c9e25dcc4c69cfd06f"
...     
  • Tests pass
  • Appropriate changes to documentation are included in the PR

K8s storage class reference: https://github.com/kubernetes/kubernetes/blob/36102b645d1a26a5945bd79173a16594c56b6aea/pkg/volume/util/storageclass.go#L60

@zoez7
Zoe Zhao (zoez7) marked this pull request as ready for review September 3, 2026 15:27
@zoez7 Zoe Zhao (zoez7) added the DO NOT MERGE This PR must not be merged yet. label Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE This PR must not be merged yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant