Avoid Istio port collision for actor egress - #1429
Open
hsteude wants to merge 2 commits into
Open
Conversation
| "--atunnel-credential-bundle="+atunnelIdentityMountPath+"/credential-bundle.pem", | ||
| "--atunnel-trust-bundle="+atunnelIdentityMountPath+"/trust-bundle.pem", | ||
| "--atunnel-egress-listen-address=0.0.0.0:15001", | ||
| "--atunnel-egress-listen-address=0.0.0.0:16001", |
Collaborator
There was a problem hiding this comment.
nit: should we keep the ate/8 theme and do 18001?
Author
There was a problem hiding this comment.
How did I miss that chance :D. Made it more at(e)sque.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #430. (see discussion)
Summary
Ateom currently uses port 15001 for intercepted Actor egress, which conflicts with Istio's outbound listener.
This changes the default to 16001 for the WorkerPool controller and both Ateom implementations. Port 16001 is not otherwise used by Substrate and does not conflict with Istio's documented ports (i'm happy to change it to somehing else tho). If useful for other integrations, I would also be happy to follow up with a configurable WorkerPool-level port.
Testing
make verifyDeployed an Istio-injected gVisor WorkerPool
Verified Actor ingress, authenticated egress, pause, suspend, and resume
Observed no listener conflicts or container restarts
Tests pass
Appropriate changes to documentation are included in the PR (not
applicable; this internal default was not previously documented)