ateapi: preserve crashes during lifecycle finalization - #1444
Open
Eitan Yarmush (EItanya) wants to merge 1 commit into
Open
ateapi: preserve crashes during lifecycle finalization#1444Eitan Yarmush (EItanya) wants to merge 1 commit into
Eitan Yarmush (EItanya) wants to merge 1 commit into
Conversation
Eitan Yarmush (EItanya)
force-pushed
the
fix/preserve-crashed-lifecycle
branch
from
September 3, 2026 18:41
60fbab0 to
a74f853
Compare
Eitan Yarmush (EItanya)
marked this pull request as ready for review
September 3, 2026 22:06
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Eitan Yarmush (EItanya)
force-pushed
the
fix/preserve-crashed-lifecycle
branch
from
September 4, 2026 13:33
a74f853 to
359b899
Compare
Eitan Yarmush (EItanya)
requested review from
Haven Xia (HavenXia),
Julian Gutierrez Oschmann (juli4n) and
Zoe Zhao (zoez7)
September 4, 2026 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CRASHEDwhen worker deletion races with resume or suspend finalizationFailedPreconditioninstead of reporting a successful invalid transitionFixes #1443
Testing
go test ./cmd/ateapi/internal/controlapi/... -count=1