Recycle a worker whose ateom container was replaced under it + telemetry coverage - #1473
Draft
Krisztian F (krisztianfekete) wants to merge 1 commit into
Draft
Conversation
Krisztian F (krisztianfekete)
force-pushed
the
feat/worker-sandbox-gone
branch
2 times, most recently
from
September 4, 2026 15:32
d9a4133 to
fe6d629
Compare
Krisztian F (krisztianfekete)
force-pushed
the
feat/worker-sandbox-gone
branch
from
September 4, 2026 15:55
fe6d629 to
3c95e49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
ateomcontainer that OOMs or crashes is restarted in place by the kubelet. Every actor on that worker stayedRUNNINGpointing at a sandbox that no longer existed.ResumeActorshort-circuits onRUNNING, so nothing would ever recover it, and the worker stayed claimed. Since the multi-actor worker API that is every actor on the worker, not one.RUNNING, unroutable, never recoversCRASHEDwithWORKER_SANDBOX_GONEand the kubelet's own reasonate.actor.crashes+ one trace joining the cause to every actor it crashedHow
WorkerStatus.ateom_container_idrecords the container a Worker is running; when the syncer sees a different one, a newRecycleWorkerRPC releases every bound actor and hands the Worker back schedulable. The record is kept rather than re-registered on purpose: an ateom reports capacity once per process andCreateWorkerleaves it unset, so a re-registered Worker would be permanently unschedulable.An
OOMKilledworker container isinfrastructure, notworkload. The limit is the operator's and the cgroup covers the sandbox runtime and every actor on the worker. Also fixesfinalizeRunningcommittingRUNNINGover an actor therelease path had already crashed.
Operational notes
Roll out ateapi before atecontroller. atecontroller now needs
deleteoncore/podsto replace a crash-looping worker.Local testing
Killing a live ateom under a running actor produced the crash with the right reason and trace, left the worker
schedulable, and a new actor was placed back on it; driving one into
CrashLoopBackOffdrained it and its Deployment replaced it.