Makefile: include all control-plane and demo images in build targets - #1490
Open
Anna Pendleton (annapendleton) wants to merge 3 commits into
Open
Conversation
Anna Pendleton (annapendleton)
requested a review
from Benjamin Elder (BenTheElder)
September 4, 2026 21:02
ate-setup treats the two ateom images as a pair: workerImages in the publish step builds and pushes ateom-gvisor and ateom-microvm together, and images.Components lists both among the packages the installer can deploy a published image for. build-images covered only gvisor, so a build from source left microvm behind and a WorkerPool pointing at the microvm sandbox class had no image for this build. The two build targets now cover images.Components exactly.
The package lists were spelled out inside the build-images and build-demos recipes, which is how they drifted from images.Components in the first place. Name the sets instead, so each package is stated once and the two targets read as the sets they build. Add SKIP_IMAGES for developer builds that want a component left out, such as the microvm image, the one image built from a debian base rather than distroless static. Nothing changes about what gets built: ko is invoked with the same flags over the same packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1489
Ran local test of makefile to confirm previous and new images are built.