Don't run PR tests on docs-only changes - #1504
Open
Tim Hockin (thockin) wants to merge 1 commit into
Open
Conversation
Collaborator
|
You can leave CI broken this way, if you're not careful. e2e: sure verify? ... one spelling linter and then CI is wedged on the next PR because we skipped it. |
Collaborator
Author
|
I'm just looking for a simple path to not waste time. |
Collaborator
|
Can we configure this per job? so we skip e2e and run the linters or something? |
Collaborator
Author
|
Seems like no, only the inverse (run job when **/*.go is touched) - that seems even more brittle |
Collaborator
Yes. strongly discourage that even more. What if we split the workflow into two? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen a few PRs which are just wasting CI time.
I don't know if this actually WORKS, of course...