fix: allow ARC4 struct from_bytes with undersized backing bytes - #72
Open
mitre88 wants to merge 1 commit into
Open
fix: allow ARC4 struct from_bytes with undersized backing bytes#72mitre88 wants to merge 1 commit into
mitre88 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AVM construction of an ARC-4 struct from a short byte string does not fail immediately. It only errors when an operation reads past the backing bytes.
Struct.from_bytes(b\"\\x00\\x00\")on a type with a large static array used to raiseinput string is not long enough to be decodedimmediately. It now stores the bytes, lets in-range fields (e.g.length) decode, and errors on out-of-range access (arr[0]).Test plan
pytest tests/arc4/test_struct.py— 15 passed (includes new short-input case)pytest tests/arc4/test_{struct,uintn,bool,string}.pyFixes #45