fix(dynamic batching): preserve static mini-batch updates - #494
Open
JimmyWang0417 wants to merge 1 commit into
Open
fix(dynamic batching): preserve static mini-batch updates#494JimmyWang0417 wants to merge 1 commit into
JimmyWang0417 wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an opt-in
keep_mini_batchoption for dynamic actor training.When enabled, dynamic micro-batch ranges are split at static mini-batch
boundaries so each optimizer update receives the same number of samples as
static batching. Metadata is copied for each yielded batch so later
iterations do not overwrite earlier batches.
The option is disabled by default to preserve existing behavior.
How was this tested?
pytest -q tests/utils/test_dynamic_batching.pypython -m compileall -q roll tests/utils/test_dynamic_batching.pygit diff --checkFixes #442