ci: fix Sauce Labs E2E browser tests with Sauce Connect 5 and legacy JWP capabilities - #33724
Merged
Merged
Conversation
…JWP capabilities - Pass `--proxy-localhost allow` to Sauce Connect 5 (`saucelabs/sauce-connect-action@v3`) in CI workflow to permit remote Sauce Labs browser VMs to access `http://localhost:2000/`. - Preserve legacy JWP capability keys (`version`, `platform`) alongside W3C capability keys (`browserVersion`, `platformName`) in `protractor-saucelabs.conf.js` for compatibility with Protractor 7 (`selenium-webdriver@3.6.0`).
angular-robot
Bot
added
the
area: build & ci
JeanMeche
approved these changes
Aug 1, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Protractor Saucelabs configuration to retain original capability properties, supporting legacy protocols. The review feedback correctly identifies that legacy JSON Wire Protocol (JWP) sessions require the tunnelIdentifier to be specified at the root level of the capabilities, as they do not recognize the W3C sauce:options block.
alan-agius4
added
target: patch
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves 4 browser test failures in
//tests:e2e.saucelabs(tests/misc/browsers.ts) caused by the Sauce Connect 5 upgrade and recent capability changes:--proxy-localhost denydefault)--proxy-localhost allowtosaucelabs/sauce-connect-action@v3in.github/workflows/ci.ymlso remote Sauce Labs browser VMs can route traffic tohttp://localhost:2000/running on the CI runner.selenium-webdriver@3.6.0Protocol Mismatchversion,platform) alongside W3C keys (browserVersion,platformName) intests/e2e/assets/protractor-saucelabs.conf.js, fixingUnable to find a matching set of capabilitieson Firefox andUnknown platform requested: 'macos 13'on Safari.