chore: bump jest and @types/jest to v30 - #475
Open
kentkwu wants to merge 1 commit into
Open
Conversation
Bumps jest 29.7.0 -> 30.3.0 and @types/jest 29.5.14 -> 30.0.0 (from dependabot apache#414), which also requires bumping ts-jest 29.1.4 -> 29.4.12 for jest ^30 peer support. ts-jest 29.4 no longer silently rewrites `module: CommonJS` to ESM when `useESM: true`, so `test/tsconfig/tsconfig.apache-arrow.json` now uses `module: NodeNext` like every other ESM test tsconfig. Without this, every suite in test:apache-arrow crashes with `ReferenceError: exports is not defined`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes the stale dependabot PR #414, which failed CI on jest 30's dropped compat and has had auto-rebases disabled for >30 days. Two additional fixes on top of the version bumps are needed to get the test matrix green.
package.json/package-lock.json— jest 29.7.0 -> 30.3.0, @types/jest 29.5.14 -> 30.0.0, and ts-jest 29.1.4 -> 29.4.12 (first ts-jest release withjest ^30peer support)test/tsconfig/tsconfig.apache-arrow.json—module: CommonJS->NodeNext, matching every other ESM test tsconfig. ts-jest 29.4 no longer rewritesmodule: CommonJSto ESM underuseESM: true, so the mismatched pair emitted CJS output that jest then loaded as ESM, crashing everytest:apache-arrowsuite withReferenceError: exports is not defined.No runtime dependencies changed and no
src/files were touched, so there is no client-visible surface change.Test Plan
npm run lint:cinpm run buildnpm test— all 13 targets (ts, src, apache-arrow, es5/es2015/esnext x cjs/esm/umd) passnpm run test:bundle— esbuild, rollup, and webpack bundles built and executed cleanRelated