Refactor NULL with nullptr in brpc/policy - #3458
Merged
Merged
Conversation
chenBright
force-pushed
the
brpc_policy_nullptr
branch
from
August 16, 2026 16:12
630d735 to
c17f06d
Compare
chenBright
force-pushed
the
brpc_policy_nullptr
branch
from
August 17, 2026 02:21
c17f06d to
b15e071
Compare
wasphin
reviewed
Aug 18, 2026
| } | ||
| if (first == 0xfb) { | ||
| // 0xFB is the lenenc NULL marker, not a length prefix. Report NULL | ||
| // 0xFB is the lenenc nullptr marker, not a length prefix. Report nullptr |
Member
There was a problem hiding this comment.
Some NULLs in the comments are protocol-level terms, not C++
null pointers.
wasphin
reviewed
Aug 18, 2026
|
|
||
| AutoConcurrencyLimiter* AutoConcurrencyLimiter::New(const AdaptiveMaxConcurrency&) const { | ||
| return new (std::nothrow) AutoConcurrencyLimiter; | ||
| return new AutoConcurrencyLimiter; |
Member
There was a problem hiding this comment.
Not sure if this change is intentional or accidental?
Member
There was a problem hiding this comment.
There are about 5 places with this change
Contributor
Author
There was a problem hiding this comment.
It's intentional. If new fails, it's basically unrecoverable; just throw a crash exception.
Member
There was a problem hiding this comment.
Better to split this into different commits.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: