[CALCITE-6284] Invalid conversion triggers ClassCastException - #5188
Open
xuzifu666 wants to merge 6 commits into
Open
[CALCITE-6284] Invalid conversion triggers ClassCastException#5188xuzifu666 wants to merge 6 commits into
xuzifu666 wants to merge 6 commits into
Conversation
xiedeyantu
approved these changes
Aug 18, 2026
mihaibudiu
reviewed
Aug 18, 2026
| /** Test case for | ||
| * <a href="https://issues.apache.org/jira/browse/CALCITE-6284">[CALCITE-6284] | ||
| * Invalid conversion triggers ClassCastException</a>. */ | ||
| @Test void bindStringParameter() { |
Contributor
There was a problem hiding this comment.
The bug report is about the message produced when the conversion FAILS.
What happens if you pass a non-numeric string?
Member
Author
There was a problem hiding this comment.
Thanks for pointing that out. The original test only covered the success path. I added bindInvalidStringParameter() and improved the error message:
Before: NumberFormatException with null message.
After: NumberFormatException: Invalid value for BigDecimal: "abc".
mihaibudiu
requested changes
Aug 18, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/CALCITE-6284