Conversation
(cherry picked from commit e967831)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #18646 (
e967831ca2a7922983e6dd1b27c2d41031574b9d) todev/1.3.Built-in sinks now wait for in-flight connector operations before discarding queued events or closing, so shutdown completes deterministically. External sinks keep the existing non-blocking discard and bounded close behavior.
dev/1.3 Adaptation
connectorIndexandoutputPipeConnectorAPIs.BUILTIN_SINKSonly from plugins available ondev/1.3; the IoT Consensus V2 aliases and display-task-ID/receiver-session APIs do not exist on this branch.Validation
mvn spotless:apply -pl iotdb-core/node-commons,iotdb-core/datanode: passed.PipeSinkSubtaskTest: passed.PipeSinkSubtaskTest: passed, 10 tests.dev/1.3sources and compilation stops on unrelated missing types such asTShowRepairDataPartitionTableProgressRespandRepairDataPartitionTableContextbefore tests run.git diff origin/dev/1.3...HEAD --check: passed.This PR has:
Key changed/added classes
PipeSinkSubtaskPipeSinkSubtaskManagerSubscriptionSinkSubtaskBuiltinPipePluginPipeSinkSubtaskTest