Skip to content

[To dev/1.3] [Pipe] Drop builtin sinks synchronously (#18646) - #18665

Open
Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:cp-e967831-dev-1.3
Open

Caideyipi wants to merge 1 commit into
apache:dev/1.3from
Caideyipi:cp-e967831-dev-1.3

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Description

Backport #18646 (e967831ca2a7922983e6dd1b27c2d41031574b9d) to dev/1.3.

Built-in sinks now wait for in-flight connector operations before discarding queued events or closing, so shutdown completes deterministically. External sinks keep the existing non-blocking discard and bounded close behavior.

dev/1.3 Adaptation

  • Preserve the legacy connectorIndex and outputPipeConnector APIs.
  • Build BUILTIN_SINKS only from plugins available on dev/1.3; the IoT Consensus V2 aliases and display-task-ID/receiver-session APIs do not exist on this branch.

Validation

  • mvn spotless:apply -pl iotdb-core/node-commons,iotdb-core/datanode: passed.
  • Targeted Java compilation of the three changed DataNode production classes and PipeSinkSubtaskTest: passed.
  • PipeSinkSubtaskTest: passed, 10 tests.
  • The normal DataNode Maven test lifecycle was also attempted, but local generated Thrift/ANTLR dependency artifacts are out of sync with the current dev/1.3 sources and compilation stops on unrelated missing types such as TShowRepairDataPartitionTableProgressResp and RepairDataPartitionTableContext before tests run.
  • git diff origin/dev/1.3...HEAD --check: passed.

This PR has:

  • been self-reviewed.
    • concurrent read and write
  • added or updated unit tests for the changed code paths.

Key changed/added classes
  • PipeSinkSubtask
  • PipeSinkSubtaskManager
  • SubscriptionSinkSubtask
  • BuiltinPipePlugin
  • PipeSinkSubtaskTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant