UI -- Workspaces can only be enabled in private projects.

[afs]

After 5 dependency updates, #4046 through to #4050, the text below is appearing in the build.

Some dependency change has brought it in workspaces. (PS eslint? but that seems to have always had it)

I think it is safe but I'd like confirmation (or fix!).

See yarnpkg/yarn#8580 around the comments yarnpkg/yarn#8580 (comment) .

[INFO] [3/4] Linking dependencies...
[INFO] warning " > @vue/eslint-config-standard@9.0.1" has incorrect peer dependency "eslint@^9.10.0".
[INFO] warning " > @vue/test-utils@2.4.11" has unmet peer dependency "@vue/compiler-dom@3.x".
[INFO] warning " > eslint-plugin-import@2.32.0" has incorrect peer dependency "eslint@^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8 || ^9".
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] warning Workspaces can only be enabled in private projects.
[INFO] [4/4] Building fresh packages...
[INFO] Done in 0.96s.

[afs]

This only happens when node_modules is rebuilt. So it might be older that current and hasn't been noticed.

[ThomasThelen]

Confirmed this on the latest build. Eslint recently added workspaces to their config and they're not marked private, which is what yarn is warning about. Yarn 1 is frozen and to my knowledge not getting any more updates. Rather than filing an issue with eslint to make workspaces private/remove them in the distribution, I think Jena would want to move to a more recent yarn version that's still getting updates. (happy to help there)

[OyvindLGjesdal]

Upgrading to a modern yarn sounds good.

I am working on an attempt following https://yarnpkg.com/migration/guide. It looks like migration to a new yarn works, but breaks some of the current scripts in package.json ($ has to be escaped for urls , env var expansion has to be changed, following the rules in https://yarnpkg.com/configuration/yarnrc?)

I tried to simplify by removing the environment-specific versions, since it looks like Yarn 4 is more OS agnostic, but the builds failed for other reasons in #4065.

Currently only linux builds ok in the actions.

I started in
https://github.com/apache/jena/compare/main...OyvindLGjesdal:jena:yarn?expand=1, but feel free to open a PR @ThomasThelen. I'm not sure if I completely understand all the changes suggested by Claude, and by looking at the docs.

I think maybe some of the ENV vars that are updated shouldn't have to be (e.g if they are not arguments, but leading env_vars).

The .yarnrc file that was generated during the migration (I think) also looks a bit broad, I changed the ageGate, but it should not be wildcard for git-repositories, and allow scripts

Summary from Claude so far:

 - Replace the install-node-and-yarn goal with install-node-and-corepack                                                                                                                                   
    (bound to generate-resources). Corepack ships with the installed Node                                                                                                                                   
    and activates the Yarn version pinned by the "packageManager" field in                                                                                                                                  
    package.json (yarn@4.17.1), so the yarn.version property is removed.                                                                                                                                    
  - Run all build/test steps through the plugin's corepack goal                                                                                                                                             
    (corepack yarn ...) instead of the yarn goal.                                                                                                                                                           
  - Use "yarn install --immutable" (the Yarn 4 equivalent of                                                                                                                                                
    --frozen-lockfile) so CI fails on lockfile drift.                                                                                                                                                       
                                                                                                                                                                                                            
  package.json:                                                                                                                                                                                             
  - Set packageManager to yarn@4.17.1 and regenerate yarn.lock in the                                                                                                                                       
    Yarn 4 format.                                                                                                                                                                                          
  - Rework test:e2e for Yarn 4's built-in portable shell, which is stricter                                                                                                                                 
    than the Yarn 1 sh passthrough: use ${VAR:-default} instead of the                                                                                                                                      
    unsupported ${VAR:=default}, escape the Fuseki "$/ping" endpoint so it                                                                                                                                  
    is not parsed as a variable, and give every port reference a default so                                                                                                                                 
    the shell does not error on an unbound variable.                                                                                                                                                        
  - Because Yarn 4's portable shell is cross-platform, collapse the                                                                                                                                         
    run-script-os / test:e2e:nix / test:e2e:win32 split into a single                                                                                                                                       
    test:e2e script and drop the run-script-os dependency and cross-env                                                                                                                                     
    usage from it.                                                                                                                                                                                          
                                                                                                                                                                                                            
  Add a Yarn 4 .yarnrc.yml (node-modules linker) and exclude it from the                                                                                                                                    
  RAT license check.                                                                                                                                                                                        
                                                                                                                                                                                                            
  Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>                   

[ThomasThelen]

Upgrading to a modern yarn sounds good.

I am working on an attempt following https://yarnpkg.com/migration/guide. It looks like migration to a new yarn works, but breaks some of the current scripts in package.json ($ has to be escaped for urls , env var expansion has to be changed, following the rules in https://yarnpkg.com/configuration/yarnrc?)

I tried to simplify by removing the environment-specific versions, since it looks like Yarn 4 is more OS agnostic, but the builds failed for other reasons in #4065.

Currently only linux builds ok in the actions.

I started in https://github.com/apache/jena/compare/main...OyvindLGjesdal:jena:yarn?expand=1, but feel free to open a PR @ThomasThelen. I'm not sure if I completely understand all the changes suggested by Claude, and by looking at the docs.

I think maybe some of the ENV vars that are updated shouldn't have to be (e.g if they are not arguments, but leading env_vars).

The .yarnrc file that was generated during the migration (I think) also looks a bit broad, I changed the ageGate, but it should not be wildcard for git-repositories, and allow scripts

Summary from Claude so far:

 - Replace the install-node-and-yarn goal with install-node-and-corepack                                                                                                                                   
    (bound to generate-resources). Corepack ships with the installed Node                                                                                                                                   
    and activates the Yarn version pinned by the "packageManager" field in                                                                                                                                  
    package.json (yarn@4.17.1), so the yarn.version property is removed.                                                                                                                                    
  - Run all build/test steps through the plugin's corepack goal                                                                                                                                             
    (corepack yarn ...) instead of the yarn goal.                                                                                                                                                           
  - Use "yarn install --immutable" (the Yarn 4 equivalent of                                                                                                                                                
    --frozen-lockfile) so CI fails on lockfile drift.                                                                                                                                                       
                                                                                                                                                                                                            
  package.json:                                                                                                                                                                                             
  - Set packageManager to yarn@4.17.1 and regenerate yarn.lock in the                                                                                                                                       
    Yarn 4 format.                                                                                                                                                                                          
  - Rework test:e2e for Yarn 4's built-in portable shell, which is stricter                                                                                                                                 
    than the Yarn 1 sh passthrough: use ${VAR:-default} instead of the                                                                                                                                      
    unsupported ${VAR:=default}, escape the Fuseki "$/ping" endpoint so it                                                                                                                                  
    is not parsed as a variable, and give every port reference a default so                                                                                                                                 
    the shell does not error on an unbound variable.                                                                                                                                                        
  - Because Yarn 4's portable shell is cross-platform, collapse the                                                                                                                                         
    run-script-os / test:e2e:nix / test:e2e:win32 split into a single                                                                                                                                       
    test:e2e script and drop the run-script-os dependency and cross-env                                                                                                                                     
    usage from it.                                                                                                                                                                                          
                                                                                                                                                                                                            
  Add a Yarn 4 .yarnrc.yml (node-modules linker) and exclude it from the                                                                                                                                    
  RAT license check.                                                                                                                                                                                        
                                                                                                                                                                                                            
  Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>                   

Thank you for this writeup! It definitely sheds some light here. I'll take a closer look at this, this upcoming week.

[afs]

Confirmed this on the latest build. Eslint recently added workspaces to their config and they're not marked private, which is what yarn is warning about. Yarn 1 is frozen and to my knowledge not getting any more updates. Rather than filing an issue with eslint to make workspaces private/remove them in the distribution, I think Jena would want to move to a more recent yarn version that's still getting updates. (happy to help there)

I've created issue #4075 to track Yarn upgrade.

Anything that reduces the JS dependency load would be great!