Skip to content

feat(keyspace): add keyspace notifications for string commands - #3600

Draft
Aetherance wants to merge 1 commit into
apache:unstablefrom
Aetherance:feat/key-notify-string
Draft

feat(keyspace): add keyspace notifications for string commands#3600
Aetherance wants to merge 1 commit into
apache:unstablefrom
Aetherance:feat/key-notify-string

Conversation

@Aetherance

Copy link
Copy Markdown
Contributor

Following #3541, which introduced the keyspace notification mechanism, this PR adds keyspace notification support for the remaining $ string command paths.

The following commands are covered:

  • SET
  • SETNX
  • SETEX
  • PSETEX
  • GETSET
  • MSET
  • MSETNX
  • MSETEX
  • APPEND
  • SETRANGE
  • INCR
  • DECR
  • INCRBY
  • DECRBY
  • INCRBYFLOAT
  • CAS

assisted by codex gpt 5.6

@Aetherance

Copy link
Copy Markdown
Contributor Author

Hi @git-hulk, @jihuayu, and @PragmaTwice, this PR is one of the follow-ups to #3541. If you have time, I’d be happy to hear your thoughts.

@Aetherance

Copy link
Copy Markdown
Contributor Author

After some consideration, I think it would be better to support replicas first, so I’ve marked this PR as a draft for now.

@Aetherance
Aetherance marked this pull request as draft August 30, 2026 05:43
@jihuayu

jihuayu commented Aug 30, 2026

Copy link
Copy Markdown
Member

After some consideration, I think it would be better to support replicas first,

Yes! I agree with you!

PS: If you'd like, you can turn these small, specific tasks into issues so others can take a look and pick them up.

@Aetherance

Copy link
Copy Markdown
Contributor Author

After some consideration, I think it would be better to support replicas first,

Yes! I agree with you!

PS: If you'd like, you can turn these small, specific tasks into issues so others can take a look and pick them up.

Sure! But that will need to wait until replica reads are implemented, since the replica-read PR may change the existing AddKeySpace API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants