Skip to content

chore(asf.yaml): refresh collaborators list and keep approvals through pushes - #1116

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:refresh-asf-yaml
Aug 26, 2026
Merged

chore(asf.yaml): refresh collaborators list and keep approvals through pushes#1116
potiuk merged 1 commit into
apache:mainfrom
potiuk:refresh-asf-yaml

Conversation

@potiuk

@potiuk potiuk commented Aug 26, 2026

Copy link
Copy Markdown
Member

Summary

  • collaborators: is trimmed to the non-ASF-members named in MISSION.md —
    johnslavik, plus shahar1, vincbeck and bugraoz93, the three Airflow
    committers from that section, now active entries rather than commented-out
    records of intent. choo121600 and the eight non-Airflow-committer ASF
    members from the PMC roster are removed. The list goes from 9 entries to 4,
    well under ASF Infra's cap of 10.
  • dismiss_stale_reviews flips to false, so an approval survives later pushes
    to the branch: a rebase or a review-comment fixup no longer forces a
    re-approval round-trip.
  • Both surrounding comment blocks are rewritten to describe the values that are
    actually in the file — they previously contradicted the config.

Type of change

  • CI / dev loop (prek, workflows, validators)

Test plan

  • prek run --files .asf.yaml passes
  • .asf.yaml parses as valid YAML
  • No code paths touched; the effective change lands when asfyaml applies the
    file on merge to main.

RFC-AI-0004 compliance

Not applicable — repository configuration only, no skill, tool, or agent
behaviour changes.

Linked issues

Notes for reviewers

The dropped PMC-roster members lose the explicit triage grant this file gave
them; those with apache GitHub org access keep reach through that route.
Worth a second pair of eyes on whether that trade is intended before merge.

@potiuk

potiuk commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

And this one to fix the ruff check #1117

…h pushes

`collaborators:` is trimmed to the non-ASF-members named in MISSION.md:
`johnslavik`, plus `shahar1`, `vincbeck` and `bugraoz93` — the three
Airflow committers from that section, now active entries instead of
commented-out records of intent. `choo121600` and the eight
non-Airflow-committer ASF members from the PMC roster are removed;
that block's comment goes with them.

`dismiss_stale_reviews` flips to `false`, so an approval survives later
pushes to the branch — a rebase or a review-comment fixup no longer
forces a re-approval round-trip.

Both surrounding comment blocks are rewritten to describe the values
that are actually in the file.
@potiuk
potiuk merged commit 07a0031 into apache:main Aug 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants