HDDS-16223. Remove racy pre-condition assertion in TestRefreshVolumeUsageHandler - #11063
Merged
Conversation
…sageHandler The test sets HDDS_NODE_REPORT_INTERVAL to 1s, so the datanode node report can reach SCM between key.close() and the assertion that SCM still shows the pre-write used space, making assertTrue(...getScmUsed().isEqual(baseline)) intermittently fail (expected true but was false). That pre-condition asserts a transient not-yet-propagated state and adds no coverage; the intended behavior (SCM eventually reflects the increased used space) is already verified by the following waitFor and assertTrue(...isGreater(baseline)). Remove the racy assertion.
chihsuan
approved these changes
Aug 20, 2026
chihsuan
left a comment
chihsuan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for patch! @rich7420 LGTM +1.
For other reviewers: I dug into the history and found that HDDS-6577 made the datanode update its cached usage on write but left this isEqual behind, so it has only been asserting that no node report has arrived yet, which HDDS_NODE_REPORT_INTERVAL=1s does not guarantee.
chungen0126
approved these changes
Aug 23, 2026
Contributor
Author
|
@chihsuan and @chungen0126 thanks for the review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The test sets HDDS_NODE_REPORT_INTERVAL to 1s, so the datanode node report can reach SCM between key.close() and the assertion that SCM still shows the pre-write used space, making assertTrue(...getScmUsed().isEqual(baseline)) intermittently fail (expected true but was false). That pre-condition asserts a transient not-yet-propagated state and adds no coverage; the intended behavior (SCM eventually reflects the increased used space) is already verified by the following waitFor and assertTrue(...isGreater(baseline)). Remove the racy assertion.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16223
How was this patch tested?
https://github.com/rich7420/ozone/actions/runs/32255956955/
https://github.com/rich7420/ozone/actions/runs/32255725038