HDDS-16253. Fix getPipelines() in Recon always returning an empty pipeline list - #11090
Open
shuan1026 wants to merge 1 commit into
Open
HDDS-16253. Fix getPipelines() in Recon always returning an empty pipeline list#11090shuan1026 wants to merge 1 commit into
shuan1026 wants to merge 1 commit into
Conversation
…ng terminal stream operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ReconContainerMetadataManagerImpl#getPipelines(ContainerKeyPrefix)builds a nestedStreampipeline to collect thePipelines for a key's block locations, but both.stream().map(...)calls are intermediate operations with no terminal operation attached. Because Java streams are lazily evaluated, thepipelines.add(...)is never actually executed, so the method unconditionally returns the emptyArrayListcreated at the top of the method.This method is the only implementation backing
ContainerMetadataIterator#next(), which is used byReconContainerMetadataManager#getContainersIterator(). That iterator feeds two REST endpoints inContainerEndpoint:GET /containers/mismatchandGET /containers/mismatch/deleted. Both currently return"pipelines": []for every container, even when the container's key actually has valid pipeline data in OM.This PR replaces the two dangling
.stream().map(...)chains with.forEach(...)What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16253
How was this patch tested?
TestReconContainerMetadataManagerImpl: 15/15 tests pass.