HDDS-16252. Avoid the per-group list copy in OmKeyInfo.verifyAndGetKeyLocations - #11091
Merged
Conversation
F64116045
marked this pull request as ready for review
August 23, 2026 03:17
Contributor
|
Thanks @F64116045 for the patch and @chungen0126 for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
OmKeyInfo.verifyAndGetKeyLocations()callscreateLocationList()only toiterate over the existing block locations and populate
allocatedBlockLocations.This change iterates over
getLocationLists()directly, avoiding theintermediate flattened list without changing the resulting block map.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16252
How was this patch tested?
A local JMH benchmark compared the affected loop with 1, 16, and 128
locations split across 1 or 4 internal lists.
createLocationList()getLocationLists()JMH 1.37, OpenJDK 17.0.17, 1 thread, 2 forks,
-prof gc.CI: https://github.com/F64116045/ozone/actions/runs/32586214700