[improve][ml] Optimize individual-ack filtering by skipping scans for batches without acked entries - #26311
Open
void-ptr974 wants to merge 1 commit into
Conversation
… batches without acked entries
void-ptr974
marked this pull request as ready for review
August 11, 2026 13:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ManagedCursorImpl.filterReadEntriesuses the global span of individually acknowledged positions to decide whether a read batch needs per-entry filtering.The span does not represent holes between acknowledged positions or ledgers. A read batch inside such a hole can therefore be treated as potentially overlapping, causing every entry in the batch to be checked and a new result list to be allocated even when the batch contains no acknowledged entries.
Modifications
PositionRangeSet.containsAnyto query whether a ledger-local entry range contains an individually acknowledged position.Verifying this change
This change added tests and can be verified as follows:
Representative JMH results on Java 21 with a batch size of 100:
The no-hit scenarios also avoid the intermediate result-list allocation. Scenarios with acknowledged entries remain comparable because they continue to use the existing per-entry filtering path.
Does this pull request potentially affect one of the following parts: