Fix ClassCastException in Record.compareTo() - #814
Open
harshitsingh070 wants to merge 1 commit into
Open
harshitsingh070 wants to merge 1 commit into
harshitsingh070 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #813
Record.compareTo()attempted to cast the underlyingObject[]values toComparable[].Since the runtime type of the array remains
Object[], this resulted in aClassCastExceptionwhen comparing records, even when the individual fields implementedComparable.Changes
Object[]toComparable[]array cast with element-wise comparison.Record.compareTo()covering equality, ordering, tie-breaking, single-field records, and dissimilar field types.Testing
Ran:
Result:
Also ran the specific regression test:
Result: