[ZEPPELIN-6641] Fix stale rationale in the reportError comment - #5424
Merged
Conversation
The comment claimed that a markForCheck() issued from outside the Angular zone has nothing to flush it. Since Angular 18 that is not accurate: hybrid scheduling notifies ChangeDetectionSchedulerImpl, and a tick is scheduled for exactly that case. State a rationale that does not depend on internal scheduling behavior. Comment only, no behavior change. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Assisted-By: Claude <noreply@anthropic.com>
Contributor
Author
|
@voidmatcha mind taking a look? Follow-up to ZEPPELIN-6565, comment only. |
voidmatcha
approved these changes
Aug 15, 2026
voidmatcha
left a comment
voidmatcha
left a comment
Member
There was a problem hiding this comment.
LGTM 👍
The new rationale does not lean on scheduling internals.
Member
|
Merged into master (cd700db). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The
reportErrorcomment inReactMountDirectiveclaimed that amarkForCheck()issued from outside the Angular zone has nothing to flush it. Since Angular 18 that is not accurate: hybrid scheduling notifiesChangeDetectionSchedulerImpl, and a tick is scheduled for exactly that case (measured at 1 to 4 ms on a running dev server, see the ZEPPELIN-6565 comment).This states a rationale that does not depend on internal scheduling behavior. Comment only, no behavior change.
What type of PR is it?
Improvement
What is the Jira issue?
How should this be tested?
Comment-only change, nothing to test.
Questions: