Include sync-only SubmitHosts in site sync refresh - #91
Open
garaimanoj wants to merge 5 commits into
Open
Conversation
garaimanoj
force-pushed
the
gt-1356-show-sites-in-detail-sync-view
branch
from
August 24, 2026 09:06
aeab7d3 to
f103673
Compare
garaimanoj
marked this pull request as ready for review
August 24, 2026 09:37
tofu-rocketry
left a comment
tofu-rocketry
left a comment
Member
There was a problem hiding this comment.
Just questions for now.
You should install the pre-commit hook locally to avoid the whitespace issues.
Contributor
Author
|
Thanks for the review. I have addressed the review comments. |
Contributor
Author
|
In JSON format dates are null. Should those be 'n/a' as well? |
Member
No, NULL in a database makes more sense. The "n/a" is a display layer thing. Makes it easier to change in future if we want to. |
tofu-rocketry
requested changes
Aug 26, 2026
tofu-rocketry
left a comment
tofu-rocketry
left a comment
Member
There was a problem hiding this comment.
Can you rebase and address the comment? Then we should be done.
| log.exception("Error while trying to refresh GridSiteSyncSubmitH") | ||
|
|
||
|
|
||
| def none_if_missing(value): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved https://stfc.atlassian.net/browse/GT-1356