chore(deps): lock file maintenance - #2107
Merged
Merged
Conversation
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2107 +/- ##
==========================================
+ Coverage 93.59% 93.61% +0.01%
==========================================
Files 181 181
Lines 12590 12590
==========================================
+ Hits 11784 11786 +2
+ Misses 806 804 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
added a commit
that referenced
this pull request
Aug 3, 2026
…aints are respected (#2110) `ScreenOptions` were not respected - with `strict=True` fingerprint generation failed, otherwise the screen constraints were silently dropped and the fingerprint got a screen outside of the requested range. `browserforge` turns the screen constraints into an allow list of user agents and passes it to the header generator, but the generator only derives browser, operating system and device from it and then samples the user agent freely - so the result is often outside the list, and the fingerprint network finds no consistent sample. `apify-fingerprint-datapoints` 0.14.0 made that deterministic for some inputs, hence the cap in #2107. `PatchedHeaderGenerator` now enforces the allow list: a user agent outside it pins the next attempt to an allowed one with the same browser, operating system and device. If nothing is interchangeable or the attempts run out, the wider header is returned, so inputs that worked before keep working. Measured on 0.14.0, before -> after: | Case | Before | After | | --- | --- | --- | | `strict` Firefox + Windows, screen `600-1800 x 400-1200` | 299/300 fail, 480 ms each | 0/500 fail, 90 ms each | | Firefox + Android, screen `300-600 x 500-1200` | ~40% of screens out of range | 0/2000 out of range | Also drops the `apify-fingerprint-datapoints<0.14.0` caps from #2107. `test_fingerprint_generator_respects_screen_options_without_strict` covers the non-strict path; it and `test_fingerprint_generator_all_options` fail on `master` with the 0.14.0 datapoints. Closes: #2108 *✍️ Drafted by Claude Code*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: (UTC)
* 0-5 * * 1)🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.