Skip to content

Use the HTTP status code to decide whether the request was successful #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apetenchea merged 1 commit into from
Aug 28, 2026
+3 −4
Merged

Use the HTTP status code to decide whether the request was successful #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions arango/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,7 @@ def prep_response(self, resp: Response, deserialize: bool = True) -> Response:
else:
resp.body = resp.raw_body

http_ok = 200 <= resp.status_code < 300
resp.is_success = http_ok and resp.error_code is None
resp.is_success = 200 <= resp.status_code < 300
return resp

def process_request(
Expand Down
4 changes: 2 additions & 2 deletions tests/test_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,15 @@ def test_response(conn):
url="test_url",
headers={"foo": "bar"},
status_text="baz",
status_code=200,
status_code=400,
raw_body=test_body,
)
conn.prep_response(response)

assert response.method == "get"
assert response.url == "test_url"
assert response.headers == {"foo": "bar"}
assert response.status_code == 200
assert response.status_code == 400
assert response.status_text == "baz"
assert response.raw_body == test_body
assert response.body == {"errorMessage": "qux", "errorNum": 1}
Expand Down
Loading