docs: document native v4/v3 adoption — linking, claim validation, build floors - #1648
Draft
NandanPrabhu wants to merge 1 commit into
Draft
docs: document native v4/v3 adoption — linking, claim validation, build floors#1648NandanPrabhu wants to merge 1 commit into
NandanPrabhu wants to merge 1 commit into
Conversation
…ld floors Covers the consumer-facing docs carved out of SDK-10039/SDK-10040 (SDK-10615): - README: correct iOS floor to 15.1 (min_ios_version_supported), state Android minSdk 26 / compileSdk 36 / JDK 17, and make the Expo requirement consistently SDK 55 for v6. - README: add iOS use_frameworks! linkage guidance. Verified by building the example app under both USE_FRAMEWORKS=static and =dynamic (pod install + iOS simulator build succeeded in each). - MIGRATION_GUIDE §9: document the opt-in ID-token claim validation state on direct token requests, with per-flow accuracy (passkey signin validates on both platforms; passkey signup, Custom Token Exchange, MFA, passwordless validate on neither — deliberate iOS/Android parity). SDK-10615
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements SDK-10615 — the consumer-facing docs carved out of SDK-10039 (Auth0.Android v4) and SDK-10040 (Auth0.swift v3).
What changed (docs only)
README.md
14.0 → 15.1(min_ios_version_supportedunder RN 0.82+). Following the old14.0value failspod install.minSdkVersion 26(Android 8.0),compileSdkVersion 36,JDK 17.use_frameworks!support.MIGRATION_GUIDE.md (§9)
Verification
Cross-checked against the branch, not the upstream migration guides.
USE_FRAMEWORKS=staticandUSE_FRAMEWORKS=dynamic—pod install(RC=0) and iOS-simulator build succeeded in both. No SDK-specificpost_installrequired.validateClaimscall sites in the repo are the passkey-signin paths (ios/NativeBridge.swift,A0Auth0Module.kt).android/gradle.properties(minSdk 26,compileSdk 36),android/build.gradle(JDK 17), andA0Auth0.podspec(Auth0 3.0.1 / JWTDecode 4.0.0 / SimpleKeychain 1.3.0,min_ios_version_supported).Divergences from the ticket (see Jira comment for detail)
CredentialsManager.swiftdoesn't wrap callbacks inTask { @MainActor in }, andWebAuthProviderisn't@Sendable @MainActor. That wrapping lives only in the Web Auth async bridge. A React Native consumer only observes a JS promise, so this item was omitted rather than document a guarantee the shipped pod lacks.platform :ios, '14.0'— that value was correct for v5. Current v6 guidance (§4) and the README both state15.1.