refactor: replace custom LRUCache with tiny-lru - #775
Merged
Conversation
- Replace internal LRUCache implementation with tiny-lru dependency - Remove dead test files for removed cache module - Remove empty tests/unit/cache/ directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the internal custom LRUCache implementation with the battle-tested tiny-lru dependency. Remove dead test files and the now-empty cache test directory.
Type of Change
Testing
npm run testpasses (removed dead tests for the old cache implementation)npm run coverage— coverage maintained (no new code to cover; removed dead code)Coverage
Checklist
npm run lintpasses