Bind registry releases to exact agent manifests - #535
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pawellisowski
added a commit
that referenced
this pull request
Sep 14, 2026
…manifest they carry Two user-facing changes since v0.137.2, in two different shipped components. `aware agent install` / `update` now enforce a release's declared identity. Every installable registry entry carries `manifest-agent` and `manifest-version`, binding the registry key to the identity the extracted `manifest.yaml` must declare. Both are required under every trust mode — official, cached and custom registries alike — validated before download (portable filename-safe agent id, strict SemVer version) and compared again after extraction, before any installed directory is created, removed or replaced. Bundle install and `update --all` inherit the checks because they call the same single-agent paths. An official bundle is `verified` only when its fresh registry binding, its receipt and the installed manifest agree, so digest equality alone can no longer credit an attested tree to a different semantic release (#535, refs #534). Releasing this now rather than waiting, because main is half-shipped: the registry is served from `refs/heads/main`, so `registry-index.json` already carries the new bindings for every user, while the binary that enforces them reaches nobody without a tag. The connection-reader bridge stops refusing valid models at two ceilings its own contract never declared (#532, refs #517). `MAX_CANONICAL_WORK_BYTES` was a bare 1 GiB module constant — invisible, unoverridable, and a silent override of the count limits `MODEL_LIMITS` does declare, making the published `maxVertices` default of 5,000,000 unreachable at 21% of it. It is now `maxCanonicalWorkBytes`: declared, overridable, fail-closed, and its refusal names the budget actually applied rather than a literal "1 GiB". `maxGlbJsonBytes` had default == hard at 16 MiB, so it was unraisable and rejected a 23,576,276-byte JSON chunk inside a GLB that `maxInputGlbBytes` admits; input and output documents now carry separate budgets, with the output bound keeping its previous strength. This ships only through a GitHub Release, which builds the Node SEA and attaches `aware-connection-reader-<version>-win-x64.zip`. Minor rather than patch: two components, a new required registry field, and install/update refusing releases they previously accepted. The delta's other two commits change no shipped behavior — #531 is an internal refactor with no caller behavior change, #529 is test-only. Gates on this tree: cargo fmt, cargo clippy -D warnings, 1,850 Rust tests across 60 suites, and the connection-reader suite (241 passed, 0 failed) all green; CI and Stats green on 9011a8e. Claude-Session: https://claude.ai/code/session_01Ah9N5qfKDMEykUBE7Jy8kZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aware agent install viewer-3d@0.1.0could report success while installing a payload whose manifest declared0.1.2. Registry entries now bind each release key to an exact manifest agent and manifest version, and install/update fail before changing installed state when the downloaded payload disagrees.The checked-in registry is backfilled with those bindings.
viewer-3d@0.1.0now points to immutable historical bytes from commitb6991920e952a0bc293308faa9090dfd2d9b570e, whose manifest declaresviewer-3d@0.1.0. Publishing, reindexing, and provenance verification enforce the same contract, with plain-English diagnostics for invalid metadata and mismatched payloads.Validation:
cargo fmt --checkcargo clippy --locked --all-targets -- -D warningscargo test --locked(1386 unit tests passed, 1 ignored; all integration suites passed)cargo run --locked -- agent reindex --checkviewer-3d@0.1.0produced manifest and receipt version0.1.0Refs #534