Skip to content

sfn-manage-batch-job-tf: Update AWS Provider to v6 - #3271

Open
kakakakakku wants to merge 4 commits into
aws-samples:mainfrom
kakakakakku:sfn-manage-batch-job-tf
Open

sfn-manage-batch-job-tf: Update AWS Provider to v6#3271
kakakakakku wants to merge 4 commits into
aws-samples:mainfrom
kakakakakku:sfn-manage-batch-job-tf

Conversation

@kakakakakku

Copy link
Copy Markdown
Contributor

Issue #, if available:
N/A

Description of changes:
Hi😀 Thanks for the useful patterns!

To keep this pattern maintainable, I updated the AWS Provider to v6.

Check

terraform apply completed successfully and works good.

image image

Thank you😀


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

compute_environment_order {
order = 1
compute_environment = aws_batch_compute_environment.batch_compute_env.arn
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

╷
│ Error: Unsupported argument
│ 
│   on main.tf line 257, in resource "aws_batch_compute_environment" "batch_compute_env":
│  257:   compute_environment_name = "BatchComputeEnvironment-${random_string.random.result}"
│ 
│ An argument named "compute_environment_name" is not expected here.
╵
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 286, in resource "aws_batch_job_queue" "batch_job_queue":
│  286:   compute_environments = [
│ 
│ An argument named "compute_environments" is not expected here.
╵

},
]
})
managed_policy_arns = ["arn:aws:iam::aws:policy/service-role/AWSBatchServiceRole"]

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

│ Warning: Argument is deprecated
│
│   with aws_iam_role.batch_role,
│   on main.tf line 221, in resource "aws_iam_role" "batch_role":
│  221:   managed_policy_arns = ["arn:aws:iam::aws:policy/service-role/AWSBatchServiceRole"]
│
│ managed_policy_arns is deprecated. Use the aws_iam_role_policy_attachment resource instead. If Terraform should exclusively manage all managed policy attachments (the current behavior of this argument), use the
│ aws_iam_role_policy_attachments_exclusive resource as well.
│
│ (and one more similar warning elsewhere)
╵

* [AWS CLI](https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2.html) installed and configured
* [Git Installed](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git)
* [AWS Serverless Application Model](https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-sam-cli-install.html) (AWS SAM) installed
* [Terraform](https://learn.hashicorp.com/tutorials/terraform/install-cli) with version 1.x installed (this pattern has been tested with version 1.15)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: This pattern use Terraform not AWS SAM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants