chore(integ-tests): tests leak a testing bucket under Atmosphere - #1956
Draft
rix0rrr wants to merge 1 commit into
Draft
chore(integ-tests): tests leak a testing bucket under Atmosphere#1956rix0rrr wants to merge 1 commit into
rix0rrr wants to merge 1 commit into
Conversation
The integ tests had a facility to clean up some stacks, and then clean up buckets that may be left behind by those tests. When introducing Atmosphere, we made the assumption that all resources would be managed by stacks, and since Atmosphere would clean up the account by deleting all stacks there would be no need to run that specific cleanup task when running under atmosphere. For most cases, `rememberToDeleteBucket()` was called as "just-in-case" mechanism, if the stack didn't fully delete for some reason or if the bucket was created with RemovalPolicy `RETAIN`. But for some cases, like in the "upgrade bootstrapping from a previous existing bootstrap bucket" case, there would be an unmanaged bucket being left behind that would only get cleaned up by the `rememberToDeleteBucket()` call.
rix0rrr
had a problem deploying
to
automation
September 10, 2026 14:24 — with 
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
rix0rrr
had a problem deploying
to
no-approval
September 10, 2026 14:24 — with
GitHub Actions
Failure
GitHub Actions
Failure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1956 +/- ##
=======================================
Coverage 91.32% 91.32%
=======================================
Files 79 79
Lines 12216 12216
Branches 1724 1724
=======================================
Hits 11156 11156
Misses 1025 1025
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integ tests had a facility to clean up some stacks, and then clean up buckets that may be left behind by those tests.
When introducing Atmosphere, we made the assumption that all resources would be managed by stacks, and since Atmosphere would clean up the account by deleting all stacks there would be no need to run that specific cleanup task when running under atmosphere.
For most cases,
rememberToDeleteBucket()was called as "just-in-case" mechanism, if the stack didn't fully delete for some reason or if the bucket was created with RemovalPolicyRETAIN. But for some cases, like in the "upgrade bootstrapping from a previous existing bootstrap bucket" case, there would be an unmanaged bucket being left behind that would only get cleaned up by therememberToDeleteBucket()call.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license