Conversation
Host the ESDK TestServer Java Language_Server in this repository under test-server/ (the smithy-java server project plus its server-config.json, feature-config.json, and bug-config.json). The server delegates to this repository's ESDK Java build via the Maven artifact (live-source mode installs it locally), so it lives with the library it exercises.
commons-configuration.json was replaced by the server-config.json / feature-config.json / bug-config.json trio in the config split but the Makefile still read the removed file; point COMMONS_CONFIGURATION at server-config.json (same commonsRepository shape) so `make test-server` resolves commons again. Its commonsRepository.branch is already lucmcdon/esdk-test-server-all-languages.
The Java move brought the server + config + Makefile but no CI workflow (workflows live at the repo root, outside test-server/), so the TestServer tests never ran on this PR. Add the orchestrated run (`make -C test-server test-server`) modeled on the sibling repos, provisioning the full cross-language toolchain matrix. Needs the COMMONS_REPO_PAT secret.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Host the ESDK TestServer Java Language_Server in this repository under
test-server/.server-config.json,feature-config.json, andbug-config.json.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: