[BUGFIX] Do not lose hidden records from localize summary - #768
Merged
Conversation
RecordSummaryForLocalization queried tt_content with the default enable-column restrictions, so hidden records were silently excluded. This broke two cases: - A child of a hidden, already-translated container could not be resolved at all: fetchOneRecord() returned null for the hidden container and the listener threw an exception. - A hidden top-level element that still needed to be localized was dropped from the summary without any error, so editors never saw it needed translation. Both queries now only exclude deleted records, keeping hidden/ start-/endtime-disabled records visible to the listener.
Contributor
Author
|
i think we have to look to workspace behaviour on a seperate task |
bmack
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecordSummaryForLocalization queried tt_content with the default enable-column restrictions, so hidden records were silently excluded.
This broke two cases:
Both queries now only exclude deleted records, keeping hidden/ start-/endtime-disabled records visible to the listener.