Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
The behavioral change is tightly scoped, aligns with the reported repro, and is covered by a targeted regression test.
Pull request overview
This PR fixes the TUI dateTimePicker so users can type full YYYY-MM-DD dates (including the - delimiter) by limiting “step date by a day” behavior to only the Up/Down arrow keys.
Changes:
- Restrict date stepping to
↑/↓only; allow all printable keys (including-) to flow to the date text input. - Update the existing step-by-day test to use
↑instead of+. - Add a regression test that types a hyphenated date and asserts it parses cleanly.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
File summaries
| File | Description |
|---|---|
| internal/tui/datetime.go | Removes +/- stepping bindings so hyphens can be typed into the date field; keeps day-stepping on arrow keys only. |
| internal/tui/datetime_test.go | Updates stepping test to use arrow keys and adds a regression test for typing hyphenated dates. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jeremy
changed the title
hey-cli#365 let the hyphen through to the date input, so YYYY-MM-DD can be typed again, and left + and = stepping the day forward. That pair was an undocumented extra: the help line only ever offered ↑↓, and with the hyphen gone the binding is one-sided, a step forward with no step back on the keys nobody was told about. Only the arrows step now; every printable key reaches the input. The typed-date test keys a whole date into an emptied field and checks it parses clean.
Follows up #365, which fixed #368 by letting the hyphen through to the date input.
What is left
#365 kept
+/=as a step-forward key. That pair was an undocumented extra — the help line only ever offered↑↓ day— and with-typed through rather than stepping back, the binding is one-sided: a step forward on keys nobody was told about, with no step back to match.dateStepanswers only the arrows now; every printable key reaches the text input. The existing step test steps back with ↑ where it used+, andTestDateTimePickerTypesADateWithItsHyphenskeys a wholeYYYY-MM-DDinto an emptied field and checks it parses clean — the reporter's repro end to end, alongside #365's separator test.