feat: uv --directory support for locking - #4029
Draft
aignas wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we will be able to decouple how the locking rule is working from
which BUILD.bazel file contains the rule. This means that we can have duplicate
invocations in the
examples/bzlmodandexamplesthat would yield exactlythe same thing, allowing us to essentially migrate all of the invocations of
compile_pip_requirementseverywhere to thelockrule.The goal is to ensure that all of the following invocations can have the same
output:
bazel run <lock_target>.runbazel run <lock_target>.updateuv <cmd>Summary:
uv pip compile --directorysupport on UNIX.uv lock --directorysupport on UNIX.uv pip compile --directorysupport on Windows.uv lock --directorysupport on Windows.tests/uv.