fix: tools.env Go 1.27 tooling pins (golangci v2.13.1 + errcheck v1.20.0) - #114
Merged
Conversation
There was a problem hiding this comment.
Consolidated Report
Must Fix (Critical): None.
Should Fix (Important):
CHANGELOG.md:1— CHANGELOG.md has no## Unreleasedbullet. This repo usesautoRelease: true; the release agent promotes## Unreleasedbullets post-merge. Without a bullet, no version ships for this change. Add a conventional-prefixed bullet (e.g.,- fix: bump errcheck to v1.20.0 for Go 1.27 compatibility). (rule:changelog/unreleased-entry-required)
Nice to Have (Optional): None.
Selector Mode Traceability:
- Candidates: 0 judgment rules matched by Step 4b-i glob filter (no
*.go,go.mod,agents/**,commands/**,skills/**, or@commitstriggers matchtools.env) - Applicable: 0 rules selected by Step 4c-sel
- Skipped: N/A — no candidates
{
"verdict": "request-changes",
"summary": "The ERRCHECK_VERSION bump from v1.10.0 to v1.20.0 is correct and consistent with golangci-lint v2.13.1 for Go 1.27, but the CHANGELOG.md is missing a ## Unreleased bullet — the autoRelease agent has nothing to promote post-merge, so no version will ship for this change.",
"comments": [
{
"file": "CHANGELOG.md",
"line": 1,
"severity": "major",
"message": "CHANGELOG.md has no ## Unreleased bullet. This repo is autoRelease=true; the release agent promotes ## Unreleased bullets post-merge. Without a bullet, no version ships for this change. Add a conventional-prefixed bullet under ## Unreleased (e.g., \"- fix: bump errcheck to v1.20.0 for Go 1.27 compatibility\")."
}
],
"concerns_addressed": [
"correctness: ERRCHECK_VERSION v1.20.0 is the correct version for golangci-lint v2.13.1 / Go 1.27 — addressed, verified by cross-referencing tools.env canonical version pins"
]
}
ben-s-pull-request-reviewer
Bot
dismissed
their stale review
August 27, 2026 22:05
superseded by new automated review
There was a problem hiding this comment.
All four versions align at 0.116.5. No issues.
Consolidated Report
Must Fix (Critical): None.
Should Fix (Important): None.
Nice to Have (Optional): None.
Notes:
tools.env:ERRCHECK_VERSIONbumpedv1.10.0 → v1.20.0for Go 1.27 compatibility. Correct pin, no issues.CHANGELOG.md: Added## Unreleasedsection with the single fix bullet. Format follows existing conventions. No issues.- Version alignment across all four files (CHANGELOG.md, plugin.json ×2, marketplace.json ×2) confirmed at
0.116.5— no drift introduced. - This is a tools-only bump; binary-relevant files (
go.mod,.gosources) unchanged, so no scenario run required per the skip rule.
Selector mode — no adjudication needed. The diff touches only tools.env and CHANGELOG.md — neither matches any rule's file-extension or path trigger. Step 4 mechanical funnel and all LLM-judged rules are a no-op for this changeset.
{
"verdict": "approve",
"summary": "Minimal, correct tooling bump: errcheck v1.10.0 → v1.20.0 for Go 1.27 compatibility, with a clean CHANGELOG entry. No correctness, security, or architectural concerns. Version alignment verified.",
"comments": [],
"concerns_addressed": []
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump tools.env pins to canonical (matches go-skeleton): golangci-lint v2.13.1 (fixes Go 1.27 stdlib export-data mismatch; v2.12.2/v2.11.4 broken) and errcheck v1.20.0 (v1.10.0 fails with 'package without types' under Go 1.27). Unblocks the update-go precommit gate.