reconcile prompts 186/187 to shipped reality - #172
Merged
Merged
Conversation
Both prompts' work landed on master on 2026-08-21 but their bookkeeping was never reconciled, leaving 186 (failed) and 187 (approved) in prompts/in-progress/ and a 186..187 gap in prompts/completed/. Because findMissingCompleted gates on presence in completed/, every prompt without a spec: field has been blocked on this repo since then. - 186 (forward check, task-manager-agent + commands/verify-task.md) shipped in c70d170; only its completion report failed validation. - 187 (inverse check, goal-manager-agent + commands/verify-goal.md) shipped in 79a6949 -- the same commit that left both files in in-progress/. Verified on master that all four target files carry the necessity steps. Neither prompt is re-run: status set to completed with the shipping commit recorded in reconciledReason, and both moved to prompts/completed/. Contiguity restored (...185, 186, 187, 188..., head 215).
There was a problem hiding this comment.
{
"verdict": "approve",
"summary": "Both prompt files are excluded from review by .reviewignore (prompts/), and the reconciliation is factually correct: the shipping commits c70d170 and 79a6949 exist and contain the expected goal-necessity forward and inverse checks respectively.",
"comments": [],
"concerns_addressed": [
{
"concern": "correctness: status transition from failed to completed for 186; reconciled/reconciledReason fields reflect c70d170",
"disposition": "addressed",
"detail": "Commit c70d170 confirmed: agents/task-manager-agent.md carries step 5 'Check goal-necessity (forward):' and commands/verify-task.md documents it. The completion report failed validation but the work shipped; reconciledReason accurately describes the gap."
},
{
"concern": "correctness: status transition from approved to completed for 187; reconciled/reconciledReason fields reflect 79a6949",
"disposition": "addressed",
"detail": "Commit 79a6949 confirmed: agents/goal-manager-agent.md carries step 8 'Check goal-necessity (inverse):' and commands/verify-goal.md documents it. The prompt was never re-run but work shipped in the same commit; reconciledReason accurately describes the gap."
}
]
}There was a problem hiding this comment.
This is a pure bookkeeping reconciliation — two completed prompt files are moved from prompts/in-progress/ to prompts/completed/ with accurate reconciled metadata and reconciledReason fields citing the correct shipping commits. No code, no security implications, no functional change.
{
"verdict": "approve",
"summary": "Pure bookkeeping PR: two prompt files (186, 187) are renamed from in-progress/ to completed/ with reconciled metadata correctly citing their shipped commits (c70d170 and 79a6949). The diff is accurate, consistent with the commit message, and requires no code review.",
"comments": [],
"concerns_addressed": []
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prompts 186 and 187 have been sitting in
prompts/in-progress/since 2026-08-21, leaving a186..187gap inprompts/completed/.findMissingCompletedgates on presence incompleted/, so every prompt without aspec:field has been blocked on this repo for three weeks.Why this is a bookkeeping fix, not a re-run
Both prompts' work already shipped:
agents/task-manager-agent.md,commands/verify-task.mdc70d170agents/goal-manager-agent.md,commands/verify-goal.md79a694979a6949is the same commit that left both files inin-progress/. 186'slastFailReasonisvalidate completion report: completion report status: failed— the completion report failed validation about 8 minutes in, after the edits had landed.Verified by content on master, not by commit subject: all four target files carry the necessity steps (
5. **Check goal-necessity (forward):**,8. **Check goal-necessity (inverse):**), including the advisory-only and unparseable-SC rules.Requeuing either prompt would re-apply edits that already exist — a no-op that fails validation again at best, a conflicting duplicate edit at worst.
Change
status: failed→completed(186),status: approved→completed(187)reconciled+reconciledReasonrecording the shipping commit and how it was verifiedprompts/completed/Contiguity restored:
…185, 186, 187, 188…, head 215.prompts/in-progress/is now empty.Markdown only — no code, no CLI surface change.
make precommitpasses.Context
Found by a fleet sweep of all 89
.dark-factory.yamlmain checkouts. This is the classdocs/running.mdcalls out asdoctor's blind spot: "a spec whose code already shipped but whose bookkeeping was never reconciled looks structurally fine" —dark-factory doctorreports this repo clean of the gap and flags neither prompt.Spec
035-verify-goal-necessity-checks(stillprompted) should follow the same reconciliation.