Skip to content

reconcile prompts 186/187 to shipped reality - #172

Merged
bborbe merged 1 commit into
masterfrom
fix/reconcile-186-187-bookkeeping
Sep 15, 2026
Merged

bborbe merged 1 commit into
masterfrom
fix/reconcile-186-187-bookkeeping

Conversation

@bborbe

@bborbe bborbe commented Sep 15, 2026

Copy link
Copy Markdown
Owner

What

Prompts 186 and 187 have been sitting in prompts/in-progress/ since 2026-08-21, leaving a 186..187 gap in prompts/completed/. findMissingCompleted gates on presence in completed/, so every prompt without a spec: field has been blocked on this repo for three weeks.

Why this is a bookkeeping fix, not a re-run

Both prompts' work already shipped:

prompt change shipped in
186 goal-necessity forward check — agents/task-manager-agent.md, commands/verify-task.md c70d170
187 goal-necessity inverse check — agents/goal-manager-agent.md, commands/verify-goal.md 79a6949

79a6949 is the same commit that left both files in in-progress/. 186's lastFailReason is validate completion report: completion report status: failed — the completion report failed validation about 8 minutes in, after the edits had landed.

Verified by content on master, not by commit subject: all four target files carry the necessity steps (5. **Check goal-necessity (forward):**, 8. **Check goal-necessity (inverse):**), including the advisory-only and unparseable-SC rules.

Requeuing either prompt would re-apply edits that already exist — a no-op that fails validation again at best, a conflicting duplicate edit at worst.

Change

  • status: failedcompleted (186), status: approvedcompleted (187)
  • reconciled + reconciledReason recording the shipping commit and how it was verified
  • both files moved to prompts/completed/

Contiguity restored: …185, 186, 187, 188…, head 215. prompts/in-progress/ is now empty.

Markdown only — no code, no CLI surface change. make precommit passes.

Context

Found by a fleet sweep of all 89 .dark-factory.yaml main checkouts. This is the class docs/running.md calls out as doctor's blind spot: "a spec whose code already shipped but whose bookkeeping was never reconciled looks structurally fine"dark-factory doctor reports this repo clean of the gap and flags neither prompt.

Spec 035-verify-goal-necessity-checks (still prompted) should follow the same reconciliation.

Both prompts' work landed on master on 2026-08-21 but their bookkeeping was
never reconciled, leaving 186 (failed) and 187 (approved) in prompts/in-progress/
and a 186..187 gap in prompts/completed/. Because findMissingCompleted gates on
presence in completed/, every prompt without a spec: field has been blocked on
this repo since then.

- 186 (forward check, task-manager-agent + commands/verify-task.md) shipped in
  c70d170; only its completion report failed validation.
- 187 (inverse check, goal-manager-agent + commands/verify-goal.md) shipped in
  79a6949 -- the same commit that left both files in in-progress/.

Verified on master that all four target files carry the necessity steps. Neither
prompt is re-run: status set to completed with the shipping commit recorded in
reconciledReason, and both moved to prompts/completed/. Contiguity restored
(...185, 186, 187, 188..., head 215).

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{
  "verdict": "approve",
  "summary": "Both prompt files are excluded from review by .reviewignore (prompts/), and the reconciliation is factually correct: the shipping commits c70d170 and 79a6949 exist and contain the expected goal-necessity forward and inverse checks respectively.",
  "comments": [],
  "concerns_addressed": [
    {
      "concern": "correctness: status transition from failed to completed for 186; reconciled/reconciledReason fields reflect c70d170",
      "disposition": "addressed",
      "detail": "Commit c70d170 confirmed: agents/task-manager-agent.md carries step 5 'Check goal-necessity (forward):' and commands/verify-task.md documents it. The completion report failed validation but the work shipped; reconciledReason accurately describes the gap."
    },
    {
      "concern": "correctness: status transition from approved to completed for 187; reconciled/reconciledReason fields reflect 79a6949",
      "disposition": "addressed",
      "detail": "Commit 79a6949 confirmed: agents/goal-manager-agent.md carries step 8 'Check goal-necessity (inverse):' and commands/verify-goal.md documents it. The prompt was never re-run but work shipped in the same commit; reconciledReason accurately describes the gap."
    }
  ]
}

@bborbe
bborbe merged commit b5a4e87 into master Sep 15, 2026
2 checks passed
@bborbe
bborbe deleted the fix/reconcile-186-187-bookkeeping branch September 15, 2026 08:45

@ben-s-pull-request-reviewer ben-s-pull-request-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pure bookkeeping reconciliation — two completed prompt files are moved from prompts/in-progress/ to prompts/completed/ with accurate reconciled metadata and reconciledReason fields citing the correct shipping commits. No code, no security implications, no functional change.

{
  "verdict": "approve",
  "summary": "Pure bookkeeping PR: two prompt files (186, 187) are renamed from in-progress/ to completed/ with reconciled metadata correctly citing their shipped commits (c70d170 and 79a6949). The diff is accurate, consistent with the commit message, and requires no code review.",
  "comments": [],
  "concerns_addressed": []
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant