Skip to content

fix(packaging): declare RepositoryUrl on ValueObjects - #3

Open
beyondnetPeru wants to merge 1 commit into
mainfrom
fix/valueobjects-package-metadata
Open

fix(packaging): declare RepositoryUrl on ValueObjects#3
beyondnetPeru wants to merge 1 commit into
mainfrom
fix/valueobjects-package-metadata

Conversation

@beyondnetPeru

Copy link
Copy Markdown
Contributor

Closes the third item of EX-01 in beyondnetcode/marketplacedocs/excepciones.md.

The defect

BeyondNetCode.Shell.Ddd.ValueObjects 1.0.0 shipped with no <repository> element — the only one of the 15 published BeyondNetCode.Shell.* packages missing it. Verified by reading the published .nuspec files straight from nuget.org: the other 14 declare it, this one does not.

That breaks the traceability rule in the marketplace distribution policy:

Trazabilidad — Todo paquete declara RepositoryUrl para quedar vinculado a su origen. Sin eso, el registro no puede heredar permisos ni nadie puede volver al código.

It is the same defect the catalog already charges against the Ums.Sdk.* packages.

Changes

   <Title>BeyondNetCode.Shell.Ddd.ValueObjects</Title>
+  <Description>Ready-made value objects for BeyondNetCode.Shell.Ddd: string, int,
+    decimal, bool and audit primitives, with composable validators for
+    identifiers and string length.</Description>
   <Copyright>BeyondNet</Copyright>
+  <PackageProjectUrl>https://github.com/beyondnetcode/Shell.ddd</PackageProjectUrl>
+  <RepositoryUrl>https://github.com/beyondnetcode/Shell.ddd</RepositoryUrl>

Beyond the strict ask, and easy to drop if you disagree: Description was the literal placeholder Package Description, which is what nuget.org would display on the next release. PackageProjectUrl was also absent while every sibling project declares it. Both are the same class of metadata gap; the description text is derived from what the project actually contains (StringValueObject, IntValueObject, DecimalValueObject, BoolValueObject, AuditValueObject, plus the Validators/ folder).

Verification

dotnet test BeyondNet.Ddd.slnx -c Release   → 58/58 passed
dotnet pack  …ValueObjects.csproj -p:PackageVersion=1.0.1-check

The produced .nuspec now carries:

<projectUrl>https://github.com/beyondnetcode/Shell.ddd</projectUrl>
<description>Ready-made value objects for BeyondNetCode.Shell.Ddd: …</description>
<repository type="git" url="https://github.com/beyondnetcode/Shell.ddd" commit="4d95387…" />

Scope

The published 1.0.0 is immutable and stays exactly as it is — per the policy, "una versión publicada no se reescribe: si sale mal, se publica la siguiente." This lands in 1.0.1, which is the next release anyway since 1.0.0 is already taken on nuget.org.

🤖 Generated with Claude Code

BeyondNetCode.Shell.Ddd.ValueObjects 1.0.0 shipped with no <repository>
element, the only one of the 15 BeyondNetCode.Shell.* packages missing
it. That breaks the traceability rule in the marketplace distribution
policy: without RepositoryUrl the registry cannot inherit permissions
and nobody can get back to the source.

Also fills the Description, which was publishing the literal
placeholder "Package Description" to nuget.org.

Recorded as EX-01 in beyondnetcode/marketplace docs/excepciones.md.
The published 1.0.0 is immutable and stays as is; this lands in 1.0.1.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant