fix(packaging): declare RepositoryUrl on ValueObjects - #3
Open
beyondnetPeru wants to merge 1 commit into
Open
Conversation
BeyondNetCode.Shell.Ddd.ValueObjects 1.0.0 shipped with no <repository> element, the only one of the 15 BeyondNetCode.Shell.* packages missing it. That breaks the traceability rule in the marketplace distribution policy: without RepositoryUrl the registry cannot inherit permissions and nobody can get back to the source. Also fills the Description, which was publishing the literal placeholder "Package Description" to nuget.org. Recorded as EX-01 in beyondnetcode/marketplace docs/excepciones.md. The published 1.0.0 is immutable and stays as is; this lands in 1.0.1. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the third item of EX-01 in
beyondnetcode/marketplace→docs/excepciones.md.The defect
BeyondNetCode.Shell.Ddd.ValueObjects1.0.0 shipped with no<repository>element — the only one of the 15 publishedBeyondNetCode.Shell.*packages missing it. Verified by reading the published.nuspecfiles straight from nuget.org: the other 14 declare it, this one does not.That breaks the traceability rule in the marketplace distribution policy:
It is the same defect the catalog already charges against the
Ums.Sdk.*packages.Changes
Beyond the strict ask, and easy to drop if you disagree:
Descriptionwas the literal placeholderPackage Description, which is what nuget.org would display on the next release.PackageProjectUrlwas also absent while every sibling project declares it. Both are the same class of metadata gap; the description text is derived from what the project actually contains (StringValueObject,IntValueObject,DecimalValueObject,BoolValueObject,AuditValueObject, plus theValidators/folder).Verification
The produced
.nuspecnow carries:Scope
The published
1.0.0is immutable and stays exactly as it is — per the policy, "una versión publicada no se reescribe: si sale mal, se publica la siguiente." This lands in 1.0.1, which is the next release anyway since1.0.0is already taken on nuget.org.🤖 Generated with Claude Code